Skip to content

Fix CI, update filter._evaluate arg order. #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix CI, update filter._evaluate arg order. #1055

merged 1 commit into from
Nov 27, 2023

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Nov 27, 2023

Closes #1054 .

@garrettwrong garrettwrong added CI Continuous Integration cleanup labels Nov 27, 2023
@garrettwrong garrettwrong requested a review from j-c-c November 27, 2023 15:17
@garrettwrong garrettwrong self-assigned this Nov 27, 2023
@garrettwrong garrettwrong requested a review from janden as a code owner November 27, 2023 15:17
j-c-c
j-c-c approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Nov 27, 2023

Thanks, merging to unblock CI.

@garrettwrong garrettwrong merged commit f8507d1 into develop Nov 27, 2023
@garrettwrong garrettwrong deleted the flk branch November 27, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

CI Continuous Integration cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c